Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pull request templates #4105

Merged
merged 2 commits into from Jun 15, 2023
Merged

feat: support pull request templates #4105

merged 2 commits into from Jun 15, 2023

Conversation

caarlos0
Copy link
Member

check if there is a .github/PULL_REQUEST_TEMPLATE.md file, and use it as body of the pull request if there is.

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Jun 15, 2023
@caarlos0 caarlos0 self-assigned this Jun 15, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 15, 2023
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 78e8264
Status: ✅  Deploy successful!
Preview URL: https://34d1ede3.goreleaser.pages.dev
Branch Preview URL: https://gh-pr-tmpl.goreleaser.pages.dev

View logs

@caarlos0 caarlos0 mentioned this pull request Jun 15, 2023
8 tasks
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #4105 (78e8264) into main (2519581) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4105      +/-   ##
==========================================
+ Coverage   83.55%   83.59%   +0.03%     
==========================================
  Files         128      128              
  Lines       11800    11825      +25     
==========================================
+ Hits         9860     9885      +25     
  Misses       1553     1553              
  Partials      387      387              
Impacted Files Coverage Δ
internal/client/github.go 60.78% <100.00%> (+2.41%) ⬆️

@caarlos0 caarlos0 merged commit bbcc45b into main Jun 15, 2023
12 checks passed
@caarlos0 caarlos0 deleted the gh-pr-tmpl branch June 15, 2023 02:28
@github-actions github-actions bot added this to the v1.19.0 milestone Jun 15, 2023
caarlos0 added a commit that referenced this pull request Jun 15, 2023
this will add support to winget into goreleaser.

Basically, the plan is:

- we generate the 3 needed yaml files 
- we commit them to a repo

and that's it.

Initially, will probably have limited options support, and will only
have the default locale.

###### TODO

- [x] docs
- [x] review by someone who knows how this works?
- [x] test install somewhere
- [x] more tests maybe?
- [x] PR templates via API?
#4105
- [x] real project test 
- [x] setup goreleaser to pr to winget as well
- [x] document sync fork stuff
#4106

---------

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant