Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check if go.mod has replace directives #4398

Merged
merged 2 commits into from Nov 4, 2023
Merged

feat: check if go.mod has replace directives #4398

merged 2 commits into from Nov 4, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 1, 2023

closes #4395

@caarlos0 caarlos0 added the enhancement New feature or request label Nov 1, 2023
@caarlos0 caarlos0 self-assigned this Nov 1, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 1, 2023
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Nov 1, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 046e0e2
Status:⚡️  Build in progress...

View logs

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023 •
edited

Codecov Report

Merging #4398 (294dde3) into main (9c54dda) will increase coverage by 0.00%.
Report is 10 commits behind head on main.
The diff coverage is 85.18%.

❗ Current head 294dde3 differs from pull request most recent head 046e0e2. Consider uploading reports for the commit 046e0e2 to get more accurate results

@@           Coverage Diff           @@
##             main    #4398   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         133      133           
  Lines       12726    12753   +27     
=======================================
+ Hits        10674    10697   +23     
- Misses       1635     1638    +3     
- Partials      417      418    +1
Files Coverage Δ
internal/pipe/gomod/gomod_proxy.go 78.94% <85.18%> (+1.93%) ⬆️

@caarlos0 caarlos0 merged commit 2223c93 into main Nov 4, 2023
8 of 10 checks passed
@caarlos0 caarlos0 deleted the proxy-check branch November 4, 2023 00:42
@github-actions github-actions bot added this to the v1.22.0 milestone Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging this pull request may close these issues.

better handle go.mod proxying when theres a replace
1 participant
@caarlos0