Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre hook failure should show command output #4451

Closed
3 tasks done
jsirianni opened this issue Nov 29, 2023 · 1 comment
Closed
3 tasks done

Pre hook failure should show command output #4451

jsirianni opened this issue Nov 29, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jsirianni
Copy link

Is your feature request related to a problem? Please describe.

We have a pre hook that is faiing for an unknown reason in CI, not reproducible locally.

  ⨯ release failed after 2m24s               error=before hook failed: hook failed: failed to run 'make release-licenses': exit status 2
Error: The process '/opt/hostedtoolcache/goreleaser-action/1.22.1-pro/x64/goreleaser' failed with exit code 1

Describe the solution you'd like

It would be nice if the pre hook failure was logged to the terminal.

Describe alternatives you've considered

Running the command on its own, before running Goreleaser.

Search

  • I did search for other open and closed issues before opening this

Supporter

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@jsirianni jsirianni added enhancement New feature or request triage Issue pending triage by one of the maintainers labels Nov 29, 2023
@caarlos0 caarlos0 removed the triage Issue pending triage by one of the maintainers label Nov 30, 2023
@caarlos0 caarlos0 added this to the v1.23.0 milestone Nov 30, 2023
@caarlos0
Copy link
Member

thanks, should be better on main 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants