Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Homebrew formula in subdirectories #67

Closed
jorinvo opened this issue Jan 14, 2017 · 6 comments · Fixed by #71
Closed

Support for Homebrew formula in subdirectories #67

jorinvo opened this issue Jan 14, 2017 · 6 comments · Fixed by #71
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jorinvo
Copy link
Contributor

jorinvo commented Jan 14, 2017

As mentioned here it's possible (and suggested) to keep formulas of a tap in a subdirectory.
Either there could be a new option to specify the dir to write to, or even simpler would be to add it to the current repo option:

To save it on the top level (as currently supported) nothing would change:

brew:
  repo: user/homebrew-tap

To use the Formula subdirectory instead you would do:

brew:
  repo: user/homebrew-tap/Formula

Am I missing any cases where this might conflict?

@caarlos0 caarlos0 self-assigned this Jan 14, 2017
@caarlos0 caarlos0 added this to the v1.0.0 milestone Jan 14, 2017
@caarlos0
Copy link
Member

Good idea, but I think its better declare it as:

brew:
  repo: user/homebrew-tap
  folder: Formula

Since repo is just the repository, not the path...

@jorinvo
Copy link
Contributor Author

jorinvo commented Jan 14, 2017

@caarlos0 yes, you are right. Better to be explizit.

@caarlos0
Copy link
Member

Nice, will work on it right now!

@caarlos0
Copy link
Member

@jorinvo #71 🍺

@jorinvo
Copy link
Contributor Author

jorinvo commented Jan 14, 2017

@caarlos0 thank you for the fast solution. It's simple and straight forward to use!

@caarlos0 caarlos0 added feature enhancement New feature or request labels Mar 6, 2018
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants