Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines on use of Borrow and Return #100

Closed
kabaka0 opened this issue Mar 22, 2017 · 1 comment
Closed

Guidelines on use of Borrow and Return #100

kabaka0 opened this issue Mar 22, 2017 · 1 comment

Comments

@kabaka0
Copy link
Collaborator

kabaka0 commented Mar 22, 2017

For consistency, it would be good to have guidelines on when to use Borrow in contributed code. It would be great if Borrow/Return could be the default for allocation (including new types going forward)- it would make contributing to the code easier, as well as make it easier to manage performance. You could probably do this without too much of a performance hit, although the Borrow/Return functions would need to become a bit more complex to make sure that returns only correspond to borrowed objects. Thoughts on this?

@kabaka0 kabaka0 changed the title Guideline on use of Borrow and Return Guidelines on use of Borrow and Return Mar 22, 2017
@kabaka0 kabaka0 mentioned this issue Mar 22, 2017
@chewxy
Copy link
Member

chewxy commented Sep 17, 2017

This issue was moved to gorgonia/tensor#12

@chewxy chewxy closed this as completed Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants