Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

'Delete blocked cookies' function deletes multifox cookies which are still in use (and were never blocked) #385

Closed
berrythesoftwarecodeprogrammar opened this issue Oct 18, 2015 · 11 comments

Comments

@berrythesoftwarecodeprogrammar

the multifox addon ( https://addons.mozilla.org/en-us/firefox/addon/multifox/ ) lets u open tabs which belong to a different 'profile', which i think is just different cookie profiles.
so i can have facebook open in a normal tab and facebook open in multifox profile 2 and both can be logged in to different accounts.

cookies belonging to multifox tabs are named weirdly like 'facebook.com.facebook-com-2.multifox', 'facebook.com.facebook-com-3.multifox' etc. (depending on the profile and the domain name).
they arent blocked by umatrix because they come from the right source and are probably just stored differently by multifox (this is good)

but when umatrix does its cookie cleanups of blocked cookies, it deletes multifox cookies even though they were never blocked ( i guess because it cant find that they belong to any tabs or something ), ive had one other addon have issues with multifox cookies like this. im not sure if addons are able to tell whether or not multifox tabs are open and if cookies belong to them. i think it might be though as the session manager addon remembers which tabs are multifox profiles when saving/restoring sessions.

log from umatrix:

14:50:56        cookie deleted: http://facebook.com.facebook-com-2.multifox/{session-cookie:wd}
14:50:56        cookie deleted: https://facebook.com.facebook-com-2.multifox/{session-cookie:presence}
14:50:56        cookie deleted: https://facebook.com.facebook-com-2.multifox/{session-cookie:xs}
14:50:56        cookie deleted: http://facebook.com.facebook-com-2.multifox/{session-cookie:_js_datr}
14:50:56        cookie deleted: http://youtube.com.youtube-com-2.multifox/{session-cookie:YSC}

would it be possible to not delete .multifox cookies when doing the blocked cookie cleanup (maybe until someone can figure out if other addons can detect multifox tabs/cookies)? i guess its kind of a bug since they were never even blocked tho

also; https://github.com/hultmann/multifox

@gorhill
Copy link
Owner

gorhill commented Oct 18, 2015

i guess its kind of a bug since they were never even blocked tho

Not a bug, by design. uMatrix will also take care of stale cookies which might be present, and will evaluate whether they must be deleted according to the matrix.

@berrythesoftwarecodeprogrammar berrythesoftwarecodeprogrammar changed the title 'Delete blocked cookies' function deleted multifox cookies which are still in use (and were never blocked) 'Delete blocked cookies' function deletes multifox cookies which are still in use (and were never blocked) Oct 18, 2015
@berrythesoftwarecodeprogrammar
Copy link
Author

oh right. could maybe the domain.multifox part be removed when checking the cookies against the matrix or something then?

@gorhill
Copy link
Owner

gorhill commented Oct 18, 2015

could maybe the domain.multifox part be removed

Of course not, that would be adding arbitrary code in uMatrix only for the sake of a very specific 3rd-party extension -- which does not exist on Chromium-based browsers. How about creating your own rule?

* multifox cookie allow

@berrythesoftwarecodeprogrammar
Copy link
Author

oh right lol ill try that

@berrythesoftwarecodeprogrammar
Copy link
Author

@gorhill, i realised even with * multifox cookie allow it still does that

19:37:43        cookie deleted: http://facebook.com.facebook-com-2.multifox/{session-cookie:_js_datr}
19:37:43        cookie deleted: http://facebook.com.facebook-com-2.multifox/{session-cookie:wd}
19:37:43        cookie deleted: http://facebook.com.facebook-com-2.multifox/{session-cookie:datr}
19:37:43        cookie deleted: http://facebook.com.facebook-com-2.multifox/{session-cookie:act}
19:37:43        cookie deleted: http://facebook.com.facebook-com-2.multifox/{session-cookie:reg_ext_ref}
19:37:43        cookie deleted: http://facebook.com.facebook-com-2.multifox/{session-cookie:_js_reg_fb_gate}
19:37:43        cookie deleted: http://facebook.com.facebook-com-2.multifox/{session-cookie:fr}
19:37:43        cookie deleted: http://facebook.com.facebook-com-2.multifox/{session-cookie:_js_reg_fb_ref}
19:37:43        cookie deleted: https://facebook.com.facebook-com-2.multifox/{session-cookie:lu}
19:37:43        cookie deleted: https://facebook.com.facebook-com-2.multifox/{session-cookie:s}
19:37:43        cookie deleted: http://facebook.com.facebook-com-2.multifox/{session-cookie:csm}
19:37:43        cookie deleted: https://facebook.com.facebook-com-2.multifox/{session-cookie:c_user}
19:37:43        cookie deleted: https://facebook.com.facebook-com-2.multifox/{session-cookie:xs}

@berrythesoftwarecodeprogrammar
Copy link
Author

it happens even when both cookie deleting options are disabled

@gorhill
Copy link
Owner

gorhill commented Nov 4, 2015

It shows only session cookies being deleted. Did you click "Delete session cookies after [...]"?

@berrythesoftwarecodeprogrammar
Copy link
Author

nope have both Delete blocked cookies. and Delete non-blocked session cookies unticked.

uMatrix 0.9.3.1
Firefox 41.0.2

@berrythesoftwarecodeprogrammar
Copy link
Author

umatrix_ dashboard-_2016-01-31_13 10 58
umatrix_log_-_2016-01-31_13 10 46
@gorhill it still happens with everything disabled, at random intervals
uMatrix 0.9.3.2
Firefox 43.0.3
and with * multifox cookie allow in rules

@berrythesoftwarecodeprogrammar
Copy link
Author

ok this is fixed now. maybe by e9e1f7e

Delete blocked cookies and Delete non-blocked session cookies do their jobs properly now and multifox cookies are no longer deleted with both of them off.

thank you!

@gorhill
Copy link
Owner

gorhill commented Feb 28, 2016

Yes, it seems to be related to #489. Sorry, I had forgotten about this entry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants