This repository has been archived by the owner on Jul 21, 2021. It is now read-only.
Adding visual cue indicating that a temp rule will be deleted if clicked #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clicking a temporary rule that is not in the permanent list, it is deleted, yet no visual cue indicates this is the intended behaviour. I initially thought it would commit the line to the permanent rules. This patch adds a line-through on :hover to signal it.
|
Good idea, thanks. |
gorhill
added a commit
that referenced
this pull request
Feb 14, 2016
Adding visual cue indicating that a temp rule will be deleted if clicked
Noxgrim
pushed a commit
to Noxgrim/uMatrix
that referenced
this pull request
Dec 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking a temporary rule that is not in the permanent list, it is
deleted, yet no visual cue indicates this is the intended behaviour. I
initially thought it would commit the line to the permanent rules.
This patch adds a line-through on :hover to signal it.