You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we run E2E tests on android devices, we disable animations to speed up tests and prevent flakiness:
adb shell settings put global window_animation_scale 0.0
adb shell settings put global transition_animation_scale 0.0
adb shell settings put global animator_duration_scale 0.0
Because of this change in Reanimated, bottom sheet doesn't show up at all if the animations are disabled on the device and BottomSheet's onClose prop is called immediately.
adb shell settings put global window_animation_scale 0.0
adb shell settings put global transition_animation_scale 0.0
adb shell settings put global animator_duration_scale 0.0
Try to open a bottom sheet
Bottom sheet gets dismissed immediately
Describe what you expected to happen:
Bottom sheet should be displayed even though the animations are disabled
Reproducible sample code
The text was updated successfully, but these errors were encountered:
Bug
Note: This issue happens with Reanimated v3 - feel free to close this issue as this library supports Reanimated v2
Reanimated has introduced ReduceMotion settings and by default it follows the system settings: https://docs.swmansion.com/react-native-reanimated/docs/guides/accessibility/
When we run E2E tests on android devices, we disable animations to speed up tests and prevent flakiness:
Because of this change in Reanimated, bottom sheet doesn't show up at all if the animations are disabled on the device and BottomSheet's
onClose
prop is called immediately.I managed to fix it by adding
reduceMotion: "never"
to ANIMATION_CONFIGS_ANDROID https://github.com/gorhom/react-native-bottom-sheet/blob/master/src/constants.ts#L77-L80 - and I expect it will work as before with Reanimated v2Environment info
Android API 34 - Emulator
Steps To Reproduce
Describe what you expected to happen:
Reproducible sample code
The text was updated successfully, but these errors were encountered: