Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] | [v2] Lacking Accessibility Support #1860

Closed
llochridge0 opened this issue Jun 5, 2024 · 8 comments
Closed

[v4] | [v2] Lacking Accessibility Support #1860

llochridge0 opened this issue Jun 5, 2024 · 8 comments
Labels
bug Something isn't working no-issue-activity

Comments

@llochridge0
Copy link

Bug

Environment info

Library Version
@gorhom/bottom-sheet 4.6.1
react-native 0.72.14
react-native-reanimated 3.3.0
react-native-gesture-handler 2.9.0

Steps To Reproduce

Open Xcode -> click on top bar (Xcode) -> Open Developer tools -> Accessibility Inspector -> Choose Simulator or device with app (that is using Bottomsheet) -> Navigate in app to location with bottomsheet.

  1. Inspect contents in bottom sheet. There are no accessibility targets other than the entire bottom sheet. label: Bottom sheet backdrop, hint: Tap to close the bottom sheet and Traits: Button

Describe what you expected to happen:

  1. When inspecting a bottomsheet each of the components/content within should retain its own accessibility labels, roles and hints

On the site it states that Gohorm BottomSheet supports accessibility, so I guess that could be subjective. Is what I'm encountering the expected outcome?

Reproducible sample code

@llochridge0 llochridge0 added the bug Something isn't working label Jun 5, 2024
@kkureli
Copy link

kkureli commented Jun 11, 2024

Hi, any solution?

@llochridge0
Copy link
Author

Hi, any solution?

Sadly I have neither seen nor heard anything on this. Best solution at this point seems to be, find an alternative.

@kkureli
Copy link

kkureli commented Jun 11, 2024

Hi, any solution?

Sadly I have neither seen nor heard anything on this. Best solution at this point seems to be, find an alternative.

Thanks for reply. Do you mean another bottom sheet library as an alternative?

@llochridge0
Copy link
Author

Hi, any solution?

Sadly I have neither seen nor heard anything on this. Best solution at this point seems to be, find an alternative.

Thanks for reply. Do you mean another bottom sheet library as an alternative?

Yes, I will likely have to find an alternate bottom sheet library (or make my own implementation)

@eirikluka
Copy link

eirikluka commented Jun 17, 2024

The whole BottomSheet has the property accessible={true} as default. If you set accessible={false} you should be able to navigate using VoiceOver / Accessibility Inspector.

I don't know why the default is true, but it might be a misunderstanding of what the property does. I've made that mistake myself.

Here's a PR from April which solves this.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@idanlevi1
Copy link

By default is accessible: true, so in IOS does not move between elements inside so my solution is:

<BottomSheetElement
            accessible={Platform.OS === 'android'}
            ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity
Projects
None yet
Development

No branches or pull requests

4 participants