Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 BottomSheetModalProvider Crashing When dismissing before Unmounting #299

Closed
ksitko opened this issue Feb 19, 2021 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@ksitko
Copy link

ksitko commented Feb 19, 2021

Bug

Hi, I'm using a BottomSheetModal to navigate away from a page when a user presses an option in a context menu. I am getting sporadic crashes with the error: sheetsQueueRef.current[sheetsQueueRef.current.length - 2].ref.current.restore

This appears to be directly connected to #240 which was resolved in V2 in #244. Was the fix ever applied to the V3 branch?

Environment info

Library Version
@gorhom/bottom-sheet 3.3.1
react-native ~0.63.4
react-native-reanimated 2.0.0-rc.3
react-native-gesture-handler 1.9.0

Steps To Reproduce

Open/Close a BottomSheetModal right before navigating.

  1. Open Modal
  2. Unmount page before Modal has closed
  3. Open another Modal
  4. Try to close the Modal

Describe what you expected to happen:

  1. Open Modal
  2. Navigate away
  3. Navigate back
  4. Open Modal
  5. Navigate away without issue

Reproducible sample code

Can do if needed but seeing as it's a repeat of a previous fixed issue in V2 I figured it redundant

@ksitko ksitko added the bug Something isn't working label Feb 19, 2021
@ksitko
Copy link
Author

ksitko commented Feb 19, 2021

Duplicate of #292, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant