Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICON_BASE_SOURCE is always required #115

Open
guilhermejcgois opened this issue Jun 16, 2020 · 0 comments
Open

ICON_BASE_SOURCE is always required #115

guilhermejcgois opened this issue Jun 16, 2020 · 0 comments
Labels
comp:ui Related to ui libraries (ui-toolkit) priority:low

Comments

@guilhermejcgois
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Writing tests for components that use gor-icon always requires a value for said token

Describe the solution you'd like
Have a default value for it and not break the DI (see #114 )

Describe alternatives you've considered
Set a default value and use @SkipSelf in IconComponent

Additional context
Add any other context or screenshots about the feature request here.

QUESTION FOR GORILA TEAM
Is a new or old component?

[ ] new component [x] old component

Is this component used by more than 2 projects?

[x] yes [ ] no

@guilhermejcgois guilhermejcgois added comp:ui Related to ui libraries (ui-toolkit) priority:low labels Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:ui Related to ui libraries (ui-toolkit) priority:low
Projects
None yet
Development

No branches or pull requests

1 participant