Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct build is not retrieved when using GitHub source #374

Closed
1 task done
ItsProfessional opened this issue Sep 6, 2023 · 3 comments
Closed
1 task done

Correct build is not retrieved when using GitHub source #374

ItsProfessional opened this issue Sep 6, 2023 · 3 comments
Labels
bug Something doesn't work as expected

Comments

@ItsProfessional
Copy link

ItsProfessional commented Sep 6, 2023

Description

Baritone makes different releases for specific versions each. The latest release at the time of writing is v1.2.19, which is for 1.12.2. A few releases prior is version v1.10.1, which is for 1.20.1.

Also, in certain releases, only forge or fabric is supported. In other releases, both are supported in a single build.

Ferium doesn't find the 1.20.1 fabric version and just says "The project is not compatible"

Steps to reproduce

  1. Run ferium add cabaletta/baritone
  2. "The project is not compatible"

Operating System

Linux

Are you using the latest version of ferium?

  • I am using the latest version of ferium

Additional Information

No response

@ItsProfessional ItsProfessional added the bug Something doesn't work as expected label Sep 6, 2023
@theRookieCoder
Copy link
Collaborator

Currently GitHub releases support is pretty finicky, it doesn't check the release description since sometimes multiple assets for different Minecraft versions could be part of the same release. So it only checks the asset filename for the mod loader and game version. Hopefully #155 will allow for more fine-tuned control based on the format of the specific repo's release style.

@theRookieCoder theRookieCoder closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
@ItsProfessional
Copy link
Author

Why is the release file name checked? Why not, just download the mod temporarily, check the game version/mod loader from the jar itself, and delete it when using ferium add?

I know it probably sounds overkill, but I mean, there's no other way to ensure that people are going to mention the mod loader/version in the release. Many people will just make an empty release, with no description or anything, with the file name being mod_id-1.0.0.jar

@theRookieCoder
Copy link
Collaborator

Downloading all the available files one-by-one, unzipping them, then parsing their contents takes significantly more time than obtaining a single JSON file with metadata about every file available, even if it might not be as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work as expected
Development

No branches or pull requests

2 participants