Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No dependency check #414

Closed
1 task done
niodtn opened this issue Apr 16, 2024 · 1 comment
Closed
1 task done

No dependency check #414

niodtn opened this issue Apr 16, 2024 · 1 comment
Labels
bug Something doesn't work as expected

Comments

@niodtn
Copy link

niodtn commented Apr 16, 2024

Description

I recently updated, but I'm having issues using it. It's not checking dependencies.
As far as I remember, before updating, it used to check the Required mods and ask whether to install Optional mods.

Steps to reproduce

  1. ferium profile create
  2. Default mods directory
  3. Minecraft version 1.20.4
  4. Fabric
  5. ferium add sodium-extra

Operating System

macOS

Are you using the latest version of ferium?

  • I am using the latest version of ferium

Additional Information

ferium installed from brew

@niodtn niodtn added the bug Something doesn't work as expected label Apr 16, 2024
@theRookieCoder
Copy link
Collaborator

theRookieCoder commented Apr 17, 2024

The previous implementation had some issues, the biggest one is that the dependencies were only dealt with when first adding the mod. They are supposed to be identified and added when upgrading mods (#99). Another issue is that it did not implement recursive dependencies (the dependencies of dependencies (and so on) were not accounted for), implementing that would be easier when #99 is added (#214).
I decided to temporarily remove the current implementation when refactoring the adding code. I wanted to implement the better solution rather than improve the existing flawed one. Unfortunately that means the feature is non-existent for the moment, but hopefully I'll be able to implement it asap.

@theRookieCoder theRookieCoder closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work as expected
Development

No branches or pull requests

2 participants