Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan the output directory and add mods found to the profile #57

Closed
theRookieCoder opened this issue May 10, 2022 · 13 comments · Fixed by #110
Closed

Scan the output directory and add mods found to the profile #57

theRookieCoder opened this issue May 10, 2022 · 13 comments · Fixed by #110
Labels
enhancement Improvements to the project fixed in source Bug has been fixed in source-code, but has not been released yet priority I'm working on it, or will be soon

Comments

@theRookieCoder
Copy link
Collaborator

theRookieCoder commented May 10, 2022

Modrinth has the functionality to find out which Version a local file belongs to (https://docs.modrinth.com/api-spec/#operation/versionFromHash)
CurseForge seems to have this functionality through 'fingerprints' but I haven't figured it out yet
Functionality for this in GitHub Releases is not possible

@JustSimplyKyle
Copy link
Contributor

So if this is added, which also means hash checking getting added too?
#34 (comment)
#49 (comment)
I think these two can also be added via the same logic
Well for github releases, maybe say something on README that it doesn't have as much functionality so use modrinth, curseforge, and then github releases

@JustSimplyKyle
Copy link
Contributor

JustSimplyKyle commented May 11, 2022

ALso which platform should we use first?
I guess modrinth would be great. But there is a slight problem with that.
Because modrinth isn't the first platform of choice for mod developers, some mod developers will have slower update cycles on modrinth.
I've encountered such problem before but I forgot which mods had them found it.
https://modrinth.com/mod/lightest-lamps/versions
https://www.curseforge.com/minecraft/mc-mods/lightest-lamps-fabric

@theRookieCoder
Copy link
Collaborator Author

which also means hash checking getting added too?

Yes, the age old problem will be fixed

@theRookieCoder
Copy link
Collaborator Author

As suggested in #64, we should also support adding mods from a file

@Cloudate9
Copy link

Cloudate9 commented May 16, 2022

Hey there, @theRookieCoder

I'm one of the main developers of ReviversMC/the-mod-index, and, although it seems you have a plan for adding this functionality, I'd like to propose our repo for helping you out.

While it is not yet complete, we're pretty dang close, and I think It'd help you a lot!
We currently do not have a Rust api though, but simple http calls to GitHub will do the job (api contributions always welcome)

If you'd like to get in touch with us for more details, you can find us on Discord 🙂

@kappa-maintainer
Copy link

I found another project that has implemented this feature for some time: https://github.com/packwiz/packwiz

@theRookieCoder theRookieCoder changed the title Scan a directory of mods and add them to the profile Scan the output directory and add mods found to the profile Jun 14, 2022
@Bluscream
Copy link

I consent with this request!

@theRookieCoder
Copy link
Collaborator Author

If you're wondering why it's taking so long, it's because I have to implement some improvements to the add command such as multiple add, nested dependencies, and a more comprehensive mod resolution checking and override flags system.

@Bluscream
Copy link

Chill. Its been only a year. Give them atleast till minecraft 1.40

@PockySweet
Copy link

One day it will happen!

@theRookieCoder
Copy link
Collaborator Author

theRookieCoder commented Jun 10, 2024

It will hopefully be soon since the primary blocking issue for this (#175) has been resolved!

@theRookieCoder
Copy link
Collaborator Author

theRookieCoder commented Jun 11, 2024

I have implemented the feature, I'll test and release it hopefully by tomorrow.

https://fosstodon.org/@theRookieCoder/112597787974114828

@theRookieCoder
Copy link
Collaborator Author

You can try it out now by compiling from the repo or using the actions artefacts.

@theRookieCoder theRookieCoder added fixed in source Bug has been fixed in source-code, but has not been released yet priority I'm working on it, or will be soon labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to the project fixed in source Bug has been fixed in source-code, but has not been released yet priority I'm working on it, or will be soon
Development

Successfully merging a pull request may close this issue.

7 participants
@Bluscream @kappa-maintainer @theRookieCoder @Cloudate9 @JustSimplyKyle @PockySweet and others