Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on why the version was considered incompatible #76

Open
dashkal16 opened this issue May 14, 2022 · 8 comments
Open

Feedback on why the version was considered incompatible #76

dashkal16 opened this issue May 14, 2022 · 8 comments
Labels
enhancement Improvements to the project

Comments

@dashkal16
Copy link

At present, when a curseforge project is not considered compatible, that's all the user is told:

PS D:\Games\PolyMC\instances\BananaCraft_1.18.2\.minecraft\mods> ferium add-curseforge 575698
Adding mod... The project/repository is not compatible

Could the error message be expanded to explain what filter(s) were not met among the files in the project?
In the above case, it turned out to be something governed by --dont-check-game-version but that was not at all obvious, especially as the mod in question does declare that it works for 1.18.2

PS D:\Games\PolyMC\instances\BananaCraft_1.18.2\.minecraft\mods> ferium add-curseforge --dont-check-game-version 575698
Adding mod... ✓ (Ars Creo)
Adding required dependency... ✓ Already added
Adding required dependency... ✓ Already added

As of this writing, the newest file for Ars Creo is https://www.curseforge.com/minecraft/mc-mods/ars-creo/files/3776248
Which is flagged for 1.18.2 and Forge

@JustSimplyKyle
Copy link
Contributor

smth like
Adding mod... The project/repository is not compatible with your game version.
add `--dont-check-game-version` if you insist to add it.
and for mod loader errors
Adding mod... The project/repository is not compatible with your mod loader.
add `--dont-check-mod-loader` if you insist to add it.

@theRookieCoder
Copy link
Collaborator

theRookieCoder commented May 15, 2022

The problem currently is that the checks are done by a single for loop and if statement (e.g curseforge checking) so this would probably require a completely different method to be used. But yeah this will definitely be a much better user experience

@theRookieCoder theRookieCoder added the enhancement Improvements to the project label May 15, 2022
@theRookieCoder
Copy link
Collaborator

And yeah for some reason Ars Creo is not adding even with the proper game version and mod loader

@theRookieCoder theRookieCoder changed the title Improved feedback when a curseforge project is considered incompatible Improved feedback when a project is considered incompatible May 15, 2022
@theRookieCoder theRookieCoder changed the title Improved feedback when a project is considered incompatible Improved feedback on what part of the version was considered incompatible May 15, 2022
@theRookieCoder theRookieCoder changed the title Improved feedback on what part of the version was considered incompatible Improved feedback on why the version was considered incompatible May 15, 2022
@theRookieCoder theRookieCoder changed the title Improved feedback on why the version was considered incompatible Feedback on why the version was considered incompatible May 15, 2022
@aschoettler
Copy link

aschoettler commented May 19, 2022

I also found that Earthcomputer/clientcommands and Coow/Cows-Odd-Widgets failed to download for 1.18.2 (even with --dont-check-modloader) despite the releases saying they are for 1.18.2.

@theRookieCoder
Copy link
Collaborator

Yes because the version is not mentioned in the actual asset name. Sigh we really have to overhaul the GitHub releases checking

@dashkal16
Copy link
Author

This hit my radar again so I checked the API myself.
The file in question doesn't have version tags when queried through the API.
They show fine in the web UI, but not over the API. So that's fun.

I checked all three of
https://api.curseforge.com/v1/mods/575698
https://api.curseforge.com/v1/mods/575698/files
https://api.curseforge.com/v1/mods/575698/files/3776248

With my own API key and the file's there, but "gameVersions": []
But...
image

@theRookieCoder
Copy link
Collaborator

theRookieCoder commented Jun 2, 2022

I don't know how the CF website works, but it probably uses a different internal API or somehow caches responses? This is an issue with CF, and I've contacted them on the discord CF Dev server and they just didn't reply at all. There's nothing I can do about this :(

I suggest you download the mod and place it in the user folder for now

@dashkal16
Copy link
Author

Indeed not. Hence the actual request.
Being told which flags would have allowed the command to succeed provides a work-around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to the project
Development

No branches or pull requests

4 participants