Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick which mod to download if multiple hits were found #95

Open
JustSimplyKyle opened this issue May 26, 2022 · 8 comments
Open

Pick which mod to download if multiple hits were found #95

JustSimplyKyle opened this issue May 26, 2022 · 8 comments
Labels
enhancement Improvements to the project

Comments

@JustSimplyKyle
Copy link
Contributor

If I'm being more specific, when option --dont-check-game-version or --dont-check-mod-loader is provided, prompt the user to choose which one should be downloaded.
The main usage for this would be github mods, since a lot of them has 1.18 in the title but not 1.18.2, but if I provide --dont-check-game-version, it will often download the incorrect version.
Notable example:
https://github.com/SpaceWalkerRS/alternate-current/releases/tag/v1.2

@theRookieCoder theRookieCoder changed the title Support for mod choosing Pick which mod to download if multiple hits were found May 26, 2022
@theRookieCoder theRookieCoder added the enhancement Improvements to the project label May 26, 2022
@theRookieCoder
Copy link
Collaborator

theRookieCoder commented May 26, 2022

My goodness, what kind of atrocity is that release? It's a complete mess! They should learn how to properly release software.

Damn, now I'm thinking I should have never got into the trouble of implementing GitHub Releases because there will inevitably be people using them completely incorrectly.

@Eskaan
Copy link
Contributor

Eskaan commented May 26, 2022

@theRookieCoder
Copy link
Collaborator

https://github.com/gorilla-devs/gdlauncher/releases/latest

wtf? Is there anything explaining what the files even are?

@Eskaan
Copy link
Contributor

Eskaan commented May 26, 2022

That's just nearly everything that gets outputted by nom run release

@JustSimplyKyle
Copy link
Contributor Author

JustSimplyKyle commented May 26, 2022

My goodness, what kind of atrocity is that release? It's a complete mess! They should learn how to properly release software.

Well a more "normal" example is VulkanMod!
https://github.com/xCollateral/VulkanMod/releases/tag/0.1.4%2B3
it's 1.18 so it doesn't work with 1.18.2, but if i ignore the check, it will download the 1.17 verison instead

@theRookieCoder
Copy link
Collaborator

Actually, this can be fixed by #29 right? Why would we need a filter and a picker?

@JustSimplyKyle
Copy link
Contributor Author

Sometimes regex filtering is difficult for newcomers to implement
But a file picker doesn't need any other user configuration

@theRookieCoder
Copy link
Collaborator

Sometimes regex filtering is difficult for newcomers to implement

I wasn't thinking of a regex, more of a glob pattern. Sort of like gh release download's glob pattern downloads. But yeah ig both would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to the project
Development

No branches or pull requests

3 participants