Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plural categories in an entry #57

Closed
wants to merge 4 commits into from

Conversation

powerivq
Copy link

@powerivq powerivq commented Sep 15, 2018

There might be multiple categories for each RSS/Atom. This PR changes the Category to an array and outputs multiple category tags.

Ref: https://validator.w3.org/feed/docs/rss2.html

category | Specify one or more categories that the channel belongs to. Follows the same rules as the <item>-level category element. More info.

@kisielk
Copy link
Contributor

kisielk commented Sep 15, 2018

Shouldn't the feed itself allow multiple categories as well?

@powerivq
Copy link
Author

@kisielk Good point. Updated to add that.

@kisielk
Copy link
Contributor

kisielk commented Sep 17, 2018

@elithrar How do you think we should go about handling changes like this? Since it's a breaking API change, technically it should be a v2.0.0 under the versioning scheme? Seems weird to cut a major revision for something seemingly minor, but maybe that's just a psychological barrier.

@stale
Copy link

stale bot commented Dec 9, 2018

This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants