Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support xml:base #87

Closed
mitranim opened this issue Mar 1, 2021 · 1 comment
Closed

Support xml:base #87

mitranim opened this issue Mar 1, 2021 · 1 comment

Comments

@mitranim
Copy link

mitranim commented Mar 1, 2021

Problem

Some feed readers (like Reeder, which is what I use) support a special "reader mode". In this mode, in-page hash links may not work properly unless the xml:base attribute is set and matches the URL of the current entry (either link or id, not sure which).

Solution

This can be solved by assigning xml:base to each entry in the feed, with the URL matching the entry's URL. Unfortunately this is not currently supported in gorilla/feeds, which caused me to make a private fork.

Attribute definition:

XmlBase string `xml:"xml:base,attr,omitempty"`

This needs to be supported in Feed, Item, RssFeedXml, RssItem, AtomFeedXml, AtomItem.

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days.

@stale stale bot added the stale label Jun 2, 2021
@stale stale bot closed this as completed Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant