Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible error in newMaskKey() implementation #36

Closed
timschreiner opened this issue Jul 24, 2014 · 1 comment
Closed

Possible error in newMaskKey() implementation #36

timschreiner opened this issue Jul 24, 2014 · 1 comment

Comments

@timschreiner
Copy link

In Conn's newMaskKey() function, I noticed the 4th byte uses the random int shifted over by 32, which unless I'm mistaken means that byte is always 0. Did you mean to use 24 instead of 32?
@garyburd
Copy link
Contributor

Fixed in bda3d7d. Thank you for the heads up.

@gorilla gorilla locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garyburd @timschreiner