Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dialer type for creating client connections #4

Closed
garyburd opened this issue Nov 5, 2013 · 2 comments
Closed

Add Dialer type for creating client connections #4

garyburd opened this issue Nov 5, 2013 · 2 comments

Comments

@garyburd
Copy link
Contributor

garyburd commented Nov 5, 2013

Add Dialer type for creating client connections:

type Dialer struct {
    // Dial specifies the dial function for creating TCP
    // connections. If Dial is nil, net.Dial is used.
    Dial func(network, addr string) (net.Conn, error)

    // TLSClientConfig specifies the TLS configuration to use with
    // tls.Client. If nil, the default configuration is used.
    TLSClientConfig *tls.Config

    // HandshakeTimeout specifies the duration for the handshake
    // to complete.
    HandshakeTimeout time.Duration

    // Input and output buffer sizes. If the buffer size is zero, then a default value
    // of 4096 is used.
    ReadBufferSize, WriteBufferSize int
]

func (d *Dialer) Dial(u *url.URL, requestHeader http.Header) (c *Conn, response *http.Response, err error)
@aglyzov
Copy link

aglyzov commented Dec 13, 2013

Hey Gary,
I wonder what's wrong with Anoop's implementation of Dialer?
https://github.com/anoopk6/websocket

What issues does it have in your opinion? Maybe I could help resolving them?

@garyburd
Copy link
Contributor Author

Fixed by 87accae

@gorilla gorilla locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants