Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable creating personal account #2

Closed
gorisanson opened this issue May 16, 2020 · 3 comments
Closed

Enable creating personal account #2

gorisanson opened this issue May 16, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@gorisanson
Copy link
Owner

Enhancement suggestion from @e6p77Bi8CW7zRBg:

It would be good if a user can create a personal account so that

  1. Number of wins and losses are recoded
  2. User have nickname
  3. Game has ranking system
@gorisanson gorisanson added the enhancement New feature or request label May 16, 2020
@gorisanson
Copy link
Owner Author

gorisanson commented May 26, 2020

Suggestion from @repeat_c, which is relevant to this issue:

Building accounts system is not that easy work, so how about showing just a part of the public IP address of the peer to prevent users from misunderstanding the identification of the peer?

@gorisanson
Copy link
Owner Author

gorisanson commented May 26, 2020

I think building accounts system is not that hard if I utilize the Firebase Authentication service. But I'm worried about the management, which would be followed after building the accounts system, which is expected not that easy because of the increase of complexity of the source code and the increase of traffic from/to the Cloud Firestore, which I utilize now, or the quick match server. I want to minimize my management work required to keep running the peer-to-peer online version. So I decided to just implement the following:

  1. Enable to show nickname to the peer. (It is from the suggestion 2 of @e6p77Bi8CW7zRBg.) The nickname is not under uniqueness test, just kept locally by Web Storage API. And it is communicated via the webRTC data channel so that it does not require any additional traffic to/from the Cloud Firestore or the quick match server.

  2. Show a part of public IP address from the peer, so that a "loose identification" could be done. (It is the suggestion of @repeat_c.) For now, since no useful information about the peer is showed, sometimes users does mistakes by thinking that they met the same peer once more in the quick match mode.

@gorisanson
Copy link
Owner Author

Showing nickname and partial public IP address function is merged to branch master by the commit 2da126e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant