Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server fails to start 95% of the time when started with the -noverify flag #81

Closed
fbricon opened this issue Oct 3, 2016 · 0 comments
Closed

Comments

@fbricon
Copy link
Contributor

fbricon commented Oct 3, 2016

So the server fails to start 95% of the time when started with the -noverify flag, and rarely succeeds, which smells like a race condition.

After some tracing, I found that, when the server is started the following happens:

  • LanguageServer application is accessed on main thread
  • it triggers JavaLanguageServerPlugin start(), which starts the JavaClientConnection which spawns some other Thread(s)
  • the Initialization handler is called before above start() ends from an LSP Thread, which NPEs on JavaLanguageServerPlugin.getLanguageServer().setParentProcessId(...); because the language server hasn't been set
  • JavaLanguageServerPlugin start() has finished, the LanguageServer is set on JavaLanguageServerPlugin the main thread. Too late.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant