Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with GridFieldOrderableRows #18

Open
brasileric opened this issue Jan 14, 2023 · 2 comments
Open

Error with GridFieldOrderableRows #18

brasileric opened this issue Jan 14, 2023 · 2 comments

Comments

@brasileric
Copy link

brasileric commented Jan 14, 2023 •
edited
Loading

In Silverstripe 4.12 (php 8.1) I get an error when I want to open a menuset. This is because $default_sort is set as an array in MenuLink.php line 86.

Changing private static $default_sort = ['Sort' => 'ASC']; to private static $default_sort = 'Sort'; will solve this.

As $default_sort should not be an array according this issue in gridfieldextensions: symbiote/silverstripe-gridfieldextensions#344
@wernerkrauss
Copy link

This will be fixed by #15
@gorriecoe any chance to merge that pull request and fix this error?

@maxime-rainville maxime-rainville mentioned this issue Mar 14, 2023
Closed
@GuySartorelli
Copy link

I recommend closing this - the underlying issue was fixed in symbiote/silverstripe-gridfieldextensions 3.5.1 and symbiote/silverstripe-gridfieldextensions 3.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wernerkrauss @brasileric @GuySartorelli