Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of conditional checks in new bash script #178

Open
JesterOrNot opened this issue Dec 27, 2019 · 0 comments
Open

Fix use of conditional checks in new bash script #178

JesterOrNot opened this issue Dec 27, 2019 · 0 comments
Labels
CodeFactor Issue found by code factor good first issue Good for newcomers

Comments

@JesterOrNot
Copy link
Member

CodeFactor found an issue: Use 'if cmd; then ..' to check exit code, or 'if [[ $(cmd) == .. ]]' to check output.

It's currently on:
tools\setup2.0.bash:15
@JesterOrNot JesterOrNot changed the title Fix 'Use 'if cmd; then ..' to check exit code, or 'if [[ $(cmd) == .. ]]' to check output.' issue in tools\setup2.0.bash Fix use of conditional checks in new bash script Dec 27, 2019
@JesterOrNot JesterOrNot added CodeFactor Issue found by code factor good first issue Good for newcomers question Further information is requested and removed question Further information is requested labels Dec 27, 2019
@JesterOrNot JesterOrNot self-assigned this Dec 29, 2019
@JesterOrNot JesterOrNot removed their assignment Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CodeFactor Issue found by code factor good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JesterOrNot