-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI pipeline and integration tests #911
Comments
You've been busy, love it! I'll go through these PRs and start reviewing/merging the ones with least dependencies. Two questions regarding integration-tests:
|
The topic is very annoying. Docker is simply not made for running multiple processes and monitoring them from a separate process (systemd)- there are solutions to start multiple processes in a container. But that won't help, because the container is used to simulate an operating system. The whole thing can only be solved by calling
All these changes run with Travis CI, Github workflow and locally on my ubuntu machine ( One issue remains open from my point of view. The test in which runlevel a service runs is not compatible with current linux versions. My knowledge of go is not great enough to investigate this. |
@dklimpel random question, are you on gophers slack by any chance? |
Which Linux (branch) is failing, I can checkout that brance and investigate next week. Wonder if it's a Goss bug, or working as intended. |
It is a problem with Debian and Ubuntu: Also on my local Ubuntu machine. |
Okay, thanks. I'll check them both out. Which PRs are next for documentation? #919? |
GitHub creates a workflow when push to master automatically. IMHO this is failing because this is a default job with Jekyll theme. Probably this can be disabled in project settings. https://github.com/goos-org/goss/settings/pages - Change to source "GitHub Action". Readthedocs should not need this, because it is working by triggers, I think. GitHub pages is not used here. |
Changed, I guess next PR to be merged will validate this? Also, please continue to use this issue to let me know the next PR in the chain. I find it a lot easier to track on here. This is an amazing level of work by the way, much appreciated. It's something I've wanted for a long time. Unfortunately, due to limited time I never got around to it, my focus tends to be:
|
Yes, it is. My suggestion for the next steps.
|
Unfortunately not. |
Hey @dklimpel , if you don't mind. Let me know on here the next PR that's ready and I'll review. This is an awesome amount of work you put it, it's greatly appreciated! |
To improve the code:
|
I have opened a few PR to move from Travis CI to Github and update integration tests.
The following proposal for processing the PR.
Independent of this, new feature:
Independent of this, fix docs:
bring back linter:
later some PR fix linting issuesbring back linter for windowsupdate integration test docker images:
After that it is possible to move from Travis CI to Github Actions.
update call of linter in makefile (example)(fix some linting failures and configure golangci-lint #922)It may be useful to provide all CIs with a uniform wording and an optimized sequence at the end.
The text was updated successfully, but these errors were encountered: