Skip to content

Commit

Permalink
beautify code
Browse files Browse the repository at this point in the history
  • Loading branch information
gossi committed Nov 16, 2016
1 parent 0adb2ce commit d075bd0
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 3 deletions.
6 changes: 5 additions & 1 deletion src/config/CodeFileGeneratorConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ protected function configureOptions(OptionsResolver $resolver) {
$resolver->setAllowedTypes('blankLineAtEnd', 'bool');
$resolver->setAllowedTypes('declareStrictTypes', 'bool');


$resolver->setNormalizer('headerComment', function (Options $options, $value) {
return $this->toDocblock($value);
});
Expand All @@ -42,6 +41,11 @@ protected function configureOptions(OptionsResolver $resolver) {
});
}

/**
*
* @param mixed $value
* @return Docblock|null
*/
private function toDocblock($value) {
if (is_string($value)) {
$value = Docblock::create()->setLongDescription($value);
Expand Down
6 changes: 5 additions & 1 deletion src/generator/builder/AbstractBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ public function __construct(ModelGenerator $generator) {
$this->config = $generator->getConfig();
}

public abstract function build(AbstractModel $model);
/**
* @param AbstractModel $model
* @return void
*/
public abstract function build($model);

protected function generate(AbstractModel $model) {
$builder = $this->generator->getFactory()->getBuilder($model);
Expand Down
6 changes: 5 additions & 1 deletion src/generator/builder/ClassBuilder.php
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
<?php
namespace gossi\codegen\generator\builder;

use gossi\codegen\generator\builder\parts\StructBuilderPart;
use gossi\codegen\model\AbstractModel;
use gossi\codegen\model\PhpClass;
use gossi\codegen\generator\builder\parts\StructBuilderPart;

class ClassBuilder extends AbstractBuilder {

use StructBuilderPart;

/**
* {@inheritDoc}
* @param PhpClass $model
*/
public function build(AbstractModel $model) {
$this->sort($model);

Expand Down
5 changes: 5 additions & 0 deletions src/generator/comparator/DefaultConstantComparator.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
use gossi\codegen\model\PhpConstant;
use phootwork\lang\Comparator;

/**
* Default property comparator
*
* Orders them by lower cased first, then upper cased
*/
class DefaultConstantComparator implements Comparator {

private $comparator;
Expand Down

0 comments on commit d075bd0

Please sign in to comment.