Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies and parser refactor #69

Closed
wants to merge 1 commit into from

Conversation

cristianoc72
Copy link
Collaborator

  • Bump php to 8+ versio
  • Bump dependencies
  • Refactor the parser for compatibility with the new nikic/php-parser version. Now the parser infers the types firstly from the code and then from the docblock

By now, tests are not green and there could be some code style errors.

- Bump php to 8+ versio
- Bump dependencies
- Refactor the parser for compatibility with the new `nikic/php-parser`
version. Now the parser infers the types firstly from the code and then
from the docblock
@cristianoc72
Copy link
Collaborator Author

@gossi I'm back from vacation and I start again to work on our libraries.

I'ld like to know your opinion about libraries namespace:

  1. continue with gossi namespace (gossi\docblock, gossi\php-code-generato etc.)
  2. change to phpowermove (phpowermove\docblock, phpowermove\php-code-generator etc.)

If we change the namespace, we should update packagist, too.

@gossi
Copy link
Collaborator

gossi commented Sep 18, 2021

I think makes more sense to use the new namespace. Usually as an end User you use the package name and copy it to github.com/ to reach for the repo. That's a nice "ui" to it, which I think is valuable to have.

Feel free to change them all.

Do they restart as v1? Or do they continue with their current version number? 🤔

@cristianoc72
Copy link
Collaborator Author

Imho we should continue to the current version number. Namespace change introduce a bc break so we should bump to the next major version.
On Packagist, it could be nice to have gossi/docblock for current version (so that a user can continue with it since he'll decide to update both version and namespace) and phpowermove/docblock starting from next version. I don't know if it's possible and how. Anyway, we'll write this change in the documentation.

@gossi
Copy link
Collaborator

gossi commented Sep 21, 2021

Yeah, makes sense. Go for it.

On packagist, you can mark a package "abandonned" and set the successor to it. That's what packagist is offering. Dunno if they "announce" it on the cli, when running the install command.

@cristianoc72
Copy link
Collaborator Author

Yeah, makes sense. Go for it.
[cut]
Dunno if they "announce" it on the cli, when running the install command.
Yes, they do.

I'm gonna close this PR: I'll re-submit it later, after changing the namespace. I started the update of the first library phpowermove/docblock#18
🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants