Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Config to call webhook on failure #181

Closed
sdawka opened this issue Mar 12, 2020 · 2 comments · Fixed by #319
Closed

[Feature Request] Config to call webhook on failure #181

sdawka opened this issue Mar 12, 2020 · 2 comments · Fixed by #319
Labels
enhancement New feature or request

Comments

@sdawka
Copy link
Contributor

sdawka commented Mar 12, 2020

Context

We needed to convert asynchronously, and don't have control over the files. However, we need to account for them, so we needed to handle the case when the conversion fails. In this case, I patched it to POST a failure notification to the webhookURL on conversion error. It would be nice if this was a feature, but since everyone may not need it, it would be nice if it was configurable.

@sdawka sdawka changed the title Config to call weebhook on failure [Feature Request] Config to call webhook on failure Mar 12, 2020
@gulien gulien added the enhancement New feature or request label Mar 13, 2020
@dcefram
Copy link

dcefram commented Jun 16, 2020

This would really be useful as right now, it just silently fails. I also made a patch on my end, but the team would rather use the official docker images. Is this an enhancement that someone is already working on? Else, we'd like to take a jab at this and submit a PR when ready?

@gulien
Copy link
Collaborator

gulien commented Jun 16, 2020

@dcefram please do 👍

@gulien gulien mentioned this issue Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants