-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[question] How to convert a website that requires javascript to continue rendering? #193
Comments
|
hi @gulien, wkhtmltopdf, another famous PDFconversion tool, solved this by providing an optional parameter called Maybe we can have something similar to this, like There is a discussion in CDP that creates an eval injection to detect the js render status, which I believe it still requires to add a 17ms delay (60 frames fresh rate) behind the wait function for the web engine actually paint the changes. Have you been already working on this? |
Hey @peterzhang41!
I was not aware of the
Yes please! 😄Feel free to provide a PR, I'll gladly review it. |
Hi gulien, https://github.com/peterzhang41/gotenberg Sorry for the delay. The PR is almost there. Unfortunately, I don't have time to finish the doc and unit-tests. Could you pick it up and finished it? My company are all-in-aws at this moment. I have to work on a lambda puppeteer solution for my project. Cheers |
@peterzhang41 thanks for your work. I plan to rewrite most of the code for the version 7.0.0 of Gotenberg, I'll take a look at what you did on your fork 👍 |
@gulien 7.0 When will it be released? |
Early fall, but it could be sooner. |
How to convert a website that requires
javascript
to continue rendering?For example, a website written in Vue, some websites need to wait for the page to render specific content due to the use of the framework, otherwise the
dom
structure is emptyThe text was updated successfully, but these errors were encountered: