HandlerError::into_response doesn't log cause

[fpgaminer]

It looks like the code for HandlerError::into_response is supposed to log the cause of the error:

gotham/gotham/src/handler/error.rs

Line 140 in 154034f

self.source().map(Error::description).unwrap_or("(none)"),

However, that doesn't seem to work; on 0.4.0 my logs just show None where the cause description should be.

As far as I can tell it's because that line is calling self.source(), but HandlerError only implements cause, not source:

gotham/gotham/src/handler/error.rs

Lines 79 to 87 in 154034f

	impl Error for HandlerError {
	fn description(&self) -> &str {
	"handler failed to process request"
	}
	fn cause(&self) -> Option<&dyn Error> {
	Some(&*self.cause)
	}
	}

And checking Error's default implementation, source will indeed return None by default.

Though, I haven't tested a patch to be sure that my theory is correct.

[colinbankier]

Thanks for the report @fpgaminer .

[whitfin]

I've pushed up #360 which might fix this, it seems like an improvement at the very least. @fpgaminer do you want to try that patch out and see if it works as you'd expect?

[msrd0]

I believe this has been fixed in #438, if not feel free to reopen.