Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically run task gc after sync #68

Closed
djmitche opened this issue Nov 28, 2020 · 1 comment · Fixed by #142
Closed

Automatically run task gc after sync #68

djmitche opened this issue Nov 28, 2020 · 1 comment · Fixed by #142
Labels
good first issue Good for newcomers

Comments

@djmitche
Copy link
Collaborator

Sync can potentially change the set of pending tasks, so it should update the working set. It's also the point where we know the replica's data is backed up, so it seems like a good time for garbage collection.

@djmitche djmitche added the good first issue Good for newcomers label Nov 28, 2020
@djmitche
Copy link
Collaborator Author

I think we'll want to have a number of maintenance operations:

  • adding pending tasks to the end of the working set, without renumbering
  • renumbering (compacting) the working set
  • sync'ing
  • expiring deleted / completed tasks N days after their last modification

Probably only the first of those should happen after a sync. TaskWarrior renumbers on every list operation, so we cold replicate that behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant