Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Universal Hot #186

Closed
apapacy opened this issue Mar 4, 2018 · 9 comments
Closed

React Universal Hot #186

apapacy opened this issue Mar 4, 2018 · 9 comments

Comments

@apapacy
Copy link

apapacy commented Mar 4, 2018

Creating a new example frontend universal (isomorphic) web app with react, react-router 4, redux, webpack 4: https://github.com/apapacy/realworld-react-universal-hot

Demo

@Cameron-C-Chapman
Copy link
Member

Looks good @apapacy! Is this done and ready for review/addition to the homepage?

@apapacy
Copy link
Author

apapacy commented Mar 9, 2018

Yes, the project is ready for review

@Cameron-C-Chapman Cameron-C-Chapman added rfc and removed wip labels Mar 9, 2018
@anishkny
Copy link
Member

hey @apapacy could you help fill out the README Getting Started section? Thanks!

@apapacy
Copy link
Author

apapacy commented Sep 25, 2018

@anishkny
Updated:
latest versions of webpack, babel
README Getting Started section

@Cameron-C-Chapman
Copy link
Member

Looks good @apapacy!

A couple of things I noticed and I think we could add it to the main page 🎉

  • Code linting should be npm run lint.
  • There is a linting error currently (although if it doesn't break the build I guess it doesn't necessarily have to be fixed but I just want to make sure you're aware of that).
8:19  error  Unable to resolve path to module '../dist/stats.generated'  import/no-unresolved
  • Running the app in dev mode or production mode is giving me an error.
TypeError: Cannot read property 'properties' of undefined
    at module.exports (/Users/cameronchapman/Personal/realworld-react-universal-hot/node_modules/webpack-cli/bin/config-yargs.js:89:48)

It seems like you're super close but I'm not able to run it. I'm on node v8.11.2. Could you update the instructions or make the fix so anyone starting from scratch can get the project running?

@apapacy
Copy link
Author

apapacy commented Oct 28, 2018

@Cameron-C-Chapman

Thank.

I fix the bug with npm run lint.

But the bug with the TypeError: Cannot read property 'properties' of undefined does not seem to be related to my project, but to webpack-cli itself. See webpack/webpack#8082

I cleaned npm_modules and executed npm install. This bug has not been reproduced.
node v8.11.2, npm 5.6.0, ubuntu 18.04.1.

@anishkny
Copy link
Member

anishkny commented Oct 30, 2018

I can reproduce error on my machine (Node 8.9.4)

npm run hot

> realworld-react-universal-hot@0.0.1 hot /Users/anish/playground/realworld-react-universal-hot
> rm -rf ./dist && mkdir ./dist && NODE_ENV=development webpack -d --config=./webpack/config.server.js --mode=development && NODE_ENV=development webpack -d --config=./webpack/config.client.js --mode=development && node ./dev_server

/Users/anish/playground/realworld-react-universal-hot/node_modules/webpack-cli/bin/config-yargs.js:89
				describe: optionsSchema.definitions.output.properties.path.description,
				                                           ^

TypeError: Cannot read property 'properties' of undefined
    at module.exports (/Users/anish/playground/realworld-react-universal-hot/node_modules/webpack-cli/bin/config-yargs.js:89:48)
    at /Users/anish/playground/realworld-react-universal-hot/node_modules/webpack-cli/bin/webpack.js:60:27
    at Object.<anonymous> (/Users/anish/playground/realworld-react-universal-hot/node_modules/webpack-cli/bin/webpack.js:515:3)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)
    at Module.require (module.js:587:17)
    at require (internal/module.js:11:18)

@apapacy could you try running this on TravisCI?

@apapacy
Copy link
Author

apapacy commented Oct 30, 2018

@Cameron-C-Chapman @anishkny

Thank. I have not reproduce a bug due to a local file package-lock.json. Now I checked the installation without this file and corrected the bug (changed the version of the weback and wenpack-cli). And now it works

@geromegrignon
Copy link
Contributor

Hello, we moved the addition of new implementations to this website : https://codebase.show/projects/realworld
Please submit your implementation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants