Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka HTTP #345

Closed
anishkny opened this issue Feb 19, 2019 · 9 comments
Closed

Akka HTTP #345

anishkny opened this issue Feb 19, 2019 · 9 comments
Labels

Comments

@anishkny
Copy link
Member

Repo in progress: https://github.com/1984weed/akka-http-realworld-example

@anishkny
Copy link
Member Author

anishkny commented Feb 19, 2019

@1984weed lets use this issue to track progress. Also, sent out a logo for Akka HTTP impl to your repo. Good luck!

@trknhr
Copy link

trknhr commented Jun 11, 2019

I left only some refactorings

@trknhr
Copy link

trknhr commented Jul 10, 2019

@anishkny
I just completed the functionality.
https://github.com/1984weed/akka-http-realworld-example
How should I do next?

@anishkny
Copy link
Member Author

Looks great! Could you fix failing build: Build Status

@trknhr
Copy link

trknhr commented Jul 10, 2019

Oh. Sorry. I made a mistake.

I fixed it. @anishkny

Thanks 🙇

@trknhr
Copy link

trknhr commented Jul 30, 2019

How do I have to do to go to the next step?

@anishkny
Copy link
Member Author

anishkny commented Aug 2, 2019

@1984weed to ensure API correctness, could you run tests defined here against your backend in CI: https://github.com/gothinkster/realworld/tree/master/api

@trknhr
Copy link

trknhr commented Aug 10, 2019

@anishkny
Copy link
Member Author

Great work. LGTM PTAL @Cameron-C-Chapman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants