馃梽馃敡 Slim #50

Closed
silentworks opened this Issue Apr 25, 2017 · 17 comments

Comments

Projects
None yet
5 participants
@silentworks

silentworks commented Apr 25, 2017

Current Status

Todo:

  • 馃弫 Fork the starter repo & post the link in this issue
  • 馃帹 Create logo for repo & update issue status (@EricSimons)
  • 馃敤 Implement all of Conduit's functionality per the spec & API
  • 馃憖 Move repo to main org & Peer review final codebase by admins/community (RFC)
  • 馃帀 Tag v1 release and officially list it on the README!

@EricSimons

This comment has been minimized.

Show comment
Hide comment
@EricSimons

EricSimons Apr 25, 2017

Member

Awesome! Just updated the issue status, created a gitter room for us to manage collaborator coordination, and created the logo for your repo's readme 馃憤:

slim

Member

EricSimons commented Apr 25, 2017

Awesome! Just updated the issue status, created a gitter room for us to manage collaborator coordination, and created the logo for your repo's readme 馃憤:

slim

@EricSimons EricSimons changed the title from Slim to 馃梽馃敡 Slim Apr 25, 2017

@EricSimons

This comment has been minimized.

Show comment
Hide comment
@EricSimons

EricSimons Apr 25, 2017

Member

@silentworks FYI some folks in the Gitter channel (https://gitter.im/realworld-dev/php-slim) are asking q's regarding what the DB layer will be, etc

Member

EricSimons commented Apr 25, 2017

@silentworks FYI some folks in the Gitter channel (https://gitter.im/realworld-dev/php-slim) are asking q's regarding what the DB layer will be, etc

@silentworks

This comment has been minimized.

Show comment
Hide comment
@silentworks

silentworks Jul 7, 2017

As I won't have the time, I am transferring this project over to @railto, will change the codebase link above to match this also.

As I won't have the time, I am transferring this project over to @railto, will change the codebase link above to match this also.

@alhoqbani

This comment has been minimized.

Show comment
Hide comment
@alhoqbani

alhoqbani Nov 8, 2017

Hi guys, are you are still working on this? I would like to build the app.

Hi guys, are you are still working on this? I would like to build the app.

@silentworks

This comment has been minimized.

Show comment
Hide comment
@silentworks

silentworks Nov 8, 2017

@alhoqbani yes this is something we will be working on

@alhoqbani yes this is something we will be working on

@alhoqbani

This comment has been minimized.

Show comment
Hide comment
@alhoqbani

alhoqbani Nov 8, 2017

Can I participate with you ? I already built something. check my repo

Can I participate with you ? I already built something. check my repo

@alhoqbani

This comment has been minimized.

Show comment
Hide comment
@alhoqbani

alhoqbani Nov 10, 2017

I finished the app. Here is a live demo: https://slim-realworld.herokuapp.com/api/articles

And here is another demo with angular as a frontend linked with the slim as backend https://angular-realworld.herokuapp.com

Should I make a separate issue proposing my codebase? @EricSimons

I finished the app. Here is a live demo: https://slim-realworld.herokuapp.com/api/articles

And here is another demo with angular as a frontend linked with the slim as backend https://angular-realworld.herokuapp.com

Should I make a separate issue proposing my codebase? @EricSimons

@Cameron-C-Chapman

This comment has been minimized.

Show comment
Hide comment
@Cameron-C-Chapman

Cameron-C-Chapman Nov 11, 2017

Member

@SandeeshS would have time to take a look at this from a code review point of view? I glanced through it and it looked fine but it's been a while since I did any php.

@alhoqbani My only feedback would be to add some more info to the README. Assume someone has never used the Slim framework. Other than composer install are there any relevant notes? How do you run tests, what is significance of the architecture and directory structure, etc. I think @SandeeshS Laravel repo is a great example of adding plenty of information to the README.

Other than that I think this is ready for listing on the README. 馃帀

Member

Cameron-C-Chapman commented Nov 11, 2017

@SandeeshS would have time to take a look at this from a code review point of view? I glanced through it and it looked fine but it's been a while since I did any php.

@alhoqbani My only feedback would be to add some more info to the README. Assume someone has never used the Slim framework. Other than composer install are there any relevant notes? How do you run tests, what is significance of the architecture and directory structure, etc. I think @SandeeshS Laravel repo is a great example of adding plenty of information to the README.

Other than that I think this is ready for listing on the README. 馃帀

@alhoqbani

This comment has been minimized.

Show comment
Hide comment
@alhoqbani

alhoqbani Nov 11, 2017

I decided to wait for the peer-review before writing the README, just in case there is any comments on the structure of the code.

However, I will prepare more detailed on the architecture and directory structure in the README soon.

I decided to wait for the peer-review before writing the README, just in case there is any comments on the structure of the code.

However, I will prepare more detailed on the architecture and directory structure in the README soon.

@silentworks

This comment has been minimized.

Show comment
Hide comment
@silentworks

silentworks Nov 12, 2017

I have reviewed the code @alhoqbani provided and it is definitely the approach I would have taken. I think it shows off quite a few of the features that Slim provide.

silentworks commented Nov 12, 2017

I have reviewed the code @alhoqbani provided and it is definitely the approach I would have taken. I think it shows off quite a few of the features that Slim provide.

@silentworks

This comment has been minimized.

Show comment
Hide comment
@silentworks

silentworks Nov 12, 2017

I have changed the codebase link above to match @alhoqbani repo as I think it should be used as the official submission. Thanks for deciding to this @alhoqbani, I am happy that someone else was able to complete this as most of us on the team have gotten real busy lately.

Hat tip to you @alhoqbani

I have changed the codebase link above to match @alhoqbani repo as I think it should be used as the official submission. Thanks for deciding to this @alhoqbani, I am happy that someone else was able to complete this as most of us on the team have gotten real busy lately.

Hat tip to you @alhoqbani

@alhoqbani

This comment has been minimized.

Show comment
Hide comment
@alhoqbani

alhoqbani Nov 12, 2017

Thanks @silentworks, glad to hear that from you.

Thanks @silentworks, glad to hear that from you.

@EricSimons

This comment has been minimized.

Show comment
Hide comment
@EricSimons

EricSimons Nov 15, 2017

Member

Excellent, excellent work @alhoqbani. That readme especially is so thorough & incredibly well done! Also, @silentworks thanks so much for chiming in here with your expertise and insight! It's seriously such an honor to have amazing folks like y'all helping push the RealWorld project forward. Thanks so much. 鉂わ笍

I've gone ahead and spun up the official repo (https://github.com/gothinkster/slim-php-realworld-example-app) and will be listing it on the homepage shortly! 馃帀

Again, amazing work y'all!!

Member

EricSimons commented Nov 15, 2017

Excellent, excellent work @alhoqbani. That readme especially is so thorough & incredibly well done! Also, @silentworks thanks so much for chiming in here with your expertise and insight! It's seriously such an honor to have amazing folks like y'all helping push the RealWorld project forward. Thanks so much. 鉂わ笍

I've gone ahead and spun up the official repo (https://github.com/gothinkster/slim-php-realworld-example-app) and will be listing it on the homepage shortly! 馃帀

Again, amazing work y'all!!

@EricSimons EricSimons closed this Nov 15, 2017

@alhoqbani

This comment has been minimized.

Show comment
Hide comment
@alhoqbani

alhoqbani Nov 15, 2017

Thanks @EricSimons, although I'm not done with the README yet. It still needs some editing, and I was hoping someone from the Slim community could review it as well.

Thanks @EricSimons, although I'm not done with the README yet. It still needs some editing, and I was hoping someone from the Slim community could review it as well.

@EricSimons

This comment has been minimized.

Show comment
Hide comment
@EricSimons

EricSimons Nov 15, 2017

Member

@alhoqbani no sweat! We can just push any updates req'd to the new repo :) Btw, do you know anyone in the Slim community I could ping about coming in to help review? Or perhaps @silentworks could review the new stuff in the readme? Lmk!

Member

EricSimons commented Nov 15, 2017

@alhoqbani no sweat! We can just push any updates req'd to the new repo :) Btw, do you know anyone in the Slim community I could ping about coming in to help review? Or perhaps @silentworks could review the new stuff in the readme? Lmk!

@alhoqbani

This comment has been minimized.

Show comment
Hide comment
@alhoqbani

alhoqbani Nov 15, 2017

unfortunately, I 'don't know any one :(

unfortunately, I 'don't know any one :(

@silentworks

This comment has been minimized.

Show comment
Hide comment
@silentworks

silentworks Nov 16, 2017

Yes I will review it. I am from the Slim community.

Yes I will review it. I am from the Slim community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment