Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: UI improvements #145

Closed
alekna opened this issue Nov 25, 2020 · 14 comments
Closed

Feature request: UI improvements #145

alekna opened this issue Nov 25, 2020 · 14 comments

Comments

@alekna
Copy link

alekna commented Nov 25, 2020

Hi,

I know that Gotify is pretty opinionated but I'll try my luck. I'm looking to switch from Pushover to Gotify as I prefer in-house hosted solutions for reliability and predictability. I thought Gotify will be a nice replacement for Pushover until I noticed certain UI differences that are show stoppers for me.

  1. Would it be possible to display absolute time as its shown in Pushover? Displaying relative time makes absolutely no sense to me because you can't tell easily when exactly event happened.

  2. I prefer seeing as many messages in a list without having to scroll. Pushover has implemented it quite nicely. Gotify message list seems to be quite bloated for me. It fits nearly 60% less of a messages compared to Pushover.

image

@jmattheis
Copy link
Member

Hi @alekna,

cool that you've tried out Gotify (:.

  1. It is already possible to see the exact timestamp by pressing the on the time (see also View precise timestamp #90).
    I think this is also usage depended / opinionated, some users prefer relative and some absolute time.
    As of this nature, this probably won't change. Also, this isn't a frequently discussed topic,
    so either users don't care or are okay with the current format.

  2. Originally, Gotify had a similar format that was changed in Make title bold #56 to support longer titles. The extra space is especially needed for smaller devices, as they normally display image, title, date & delete button in the same I'd be ok with reducing the image size, but that probably won't change much.

@alekna
Copy link
Author

alekna commented Nov 26, 2020

Hi @jmattheis, thanks for your reply.

  1. It would be nice if default View precise timestamp #90 behavior was configurable in Settings. Can't imagine sane user whose preference is absolute time clicking on each notification. Sad to hear this won't change. If this software wasn't so much opinionated probably community would discuss topics like this more actively.

  2. Now exactly sure how Make title bold #56 improved support for longer titles as in Pushover I can fit more information before title gets wrapped and it doesn't come at an expense of message list size.

image

@jmattheis
Copy link
Member

Hey again,

  1. I understand the reasoning and would be ok with adding such a setting.
  2. Well because it should be possible to differentiate the title from the message, we made it bold and a little bigger. To still allow bigger titles the title was moved above the Message/Image. But yeah, I understand your argument.

@RemiRigal
Copy link
Contributor

About the layout of the messages, what about having a setting to choose the size ? It could be as follow:

  • Small: Display image as an inline icon with the title
  • Medium: Same as the Pushover example
  • Large: Same as it is now

@alekna
Copy link
Author

alekna commented Mar 18, 2021

@RemiRigal sounds good to me. Are you willing to implement it?

@RemiRigal
Copy link
Contributor

I will probably have some time to do this in April. I would like to have @jmattheis approval or opinion first though, I don't want to spend time on something that won't be merged.

@jmattheis
Copy link
Member

Sure, I'd be okay with different message layout settings. But I like to keep it simple, so how about two settings like "normal" and "compact"?

@alekna
Copy link
Author

alekna commented May 14, 2021

@RemiRigal how's your progress with this feature?

@cyb3rko
Copy link
Contributor

cyb3rko commented Oct 8, 2022

@alekna @jmattheis I played around and implemented a compact message layout.
What do you think?

"Normal":
Before

"Compact":
Before

And I think especially for the compact layout we don't really need the trash can as you can simply swipe the message to the left to delete it, right?

@jmattheis
Copy link
Member

Looks great! I'm not sure if we should omit the trash icon, as it allows you to delete messages much faster than by swiping, but this could be changed later if that's a problem for some users.

@cyb3rko
Copy link
Contributor

cyb3rko commented Oct 9, 2022

Okay, I'm going to prepare a pull request for this (and bring the trash icon to the compact layout as well).

@cyb3rko
Copy link
Contributor

cyb3rko commented Oct 10, 2022

Compact message layout added in #246.
As both points @alekna mentioned are implemented, it's finally time to close this, right?

@alekna
Copy link
Author

alekna commented Oct 11, 2022

Correct, @cyb3rko. Thank you! :)

@cyb3rko
Copy link
Contributor

cyb3rko commented Oct 11, 2022

Glad I could contribute.
I just found this repo and decided to implement this here, as it has been staling for 2 years now 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants