Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown is entirely re-rendered as you're scrolling up and down, resulting in images redownloading #79

Closed
beerendlauwers opened this issue Sep 27, 2019 · 2 comments
Closed

Markdown is entirely re-rendered as you're scrolling up and down, resulting in images redownloading #79

beerendlauwers opened this issue Sep 27, 2019 · 2 comments

Comments

@beerendlauwers
Copy link

Issue: After pushing a few Markdown-formatted messages with images in them, older messages are pushed downwards. After a message is out of the view bounds, it seems to be "forgotten" about: scrolling back to a message you previously viewed re-renders the message and downloads the image all over again.

Suggestion: Cache images in notifications on the device. As soon as a notification is deleted, any accompanying images for that notification are removed from the cache.
@jmattheis
Copy link
Member

With d9113a8 images will be cached between rerenders.

Full caching could be integrated via #58 or #86 so I'm closing this issue.

@beerendlauwers
Copy link
Author

Just tested it, works stellar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beerendlauwers @jmattheis