Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A proposal of access control #595

Closed
ywjheart opened this issue Oct 2, 2023 · 1 comment
Closed

A proposal of access control #595

ywjheart opened this issue Oct 2, 2023 · 1 comment
Labels
a:feature New feature or request

Comments

@ywjheart
Copy link

ywjheart commented Oct 2, 2023

Is your feature request related to a problem? Please describe.
Gotify doesn't have a right/access control to users/applications/clients so far

Describe the solution you'd like
There are two user level in Gotify so far, admin and non-admin.
My proposal:
Applications should be available to admins by default, but not non-admins. Admins can assign applications to non-admins, toggle for each user if there are multi non-admins.
Clients is signed in by a user at the moment, it should receive all messages from all applications belong to the user by default, a user should be able to toggle whether receives messages of an application, either from android clients or from Web UI.
All of the access control happens on the gotify server, older clients still can work with newer servers, because it will receive a reduced application list and received what message routed to it.

Describe alternatives you've considered

Additional context

@ywjheart ywjheart added the a:feature New feature or request label Oct 2, 2023
@ywjheart ywjheart changed the title A purposal of access/subscription control A proposal of access/subscription control Oct 2, 2023
@ywjheart ywjheart changed the title A proposal of access/subscription control A proposal of access control Oct 2, 2023
@jmattheis
Copy link
Member

I'd say Gotify has access control, tho only a really simple one where applications / clients are bound to only one user. There are already some issues about this namely gotify/contrib#5, #334 and a few more.

Implementing a new model for this would require a major rework which I don't think is in scope for this project. You could try out https://github.com/eternal-flame-AD/gotify-broadcast which implements an access control model similar to the one you proposed.

@jmattheis jmattheis closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature New feature or request
Development

No branches or pull requests

2 participants