Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split library into readers and data model #54

Open
goto-bus-stop opened this issue Oct 20, 2017 · 0 comments
Open

split library into readers and data model #54

goto-bus-stop opened this issue Oct 20, 2017 · 0 comments

Comments

@goto-bus-stop
Copy link
Owner

goto-bus-stop commented Oct 20, 2017

Right now Analyzers return class instances, or sometimes they don't. They also read data from the recorded game file on demand, which can be nice, but which makes it more difficult to store data that's been read. For example, if you want to upload a rec, and then show the localized civilization names later, that's not really possible because the civName() method is tied to the Analyzer class.

It'd be neat if RecAnalyst was essentially two steps: reading data, and a modeling layer on top of that data. The readers would just return JSON. It could still read on demand, but you could also read everything, store the JSON somewhere, and create a new RecAnalyst instance based on that JSON blob to get the nice API without having to re-analyze the rec.

Probably going to try to align the JSON format with recage.

@goto-bus-stop goto-bus-stop changed the title split source into readers and data model split library into readers and data model Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant