New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: Field 取代 FieldByName #83
Conversation
longyue0521
commented
Aug 19, 2022
- mode.go 添加Index字段
- mode_test.go 测试Index字段
- reflect.go 使用自定义field方法(本质reflect.Value.Field)替换reflect.Value.FieldByName方法
- unsafe_test.go 添加测试用例NullBoolPtr
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 81.56% 81.66% +0.09%
==========================================
Files 17 17
Lines 1123 1129 +6
==========================================
+ Hits 916 922 +6
Misses 175 175
Partials 32 32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
deepsource 里面有一个检查没过,你可以把 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 把 field 的名字改一下,然后加一个 bool 作为返回值,== (reflect.Value) 还是比较丑的。
- 然后把 Index 改成 FieldIndex
- 然后在 .CHANGELOG 里面加一条记录,也就是这个 MR
不好意思,因为处理冲突不当导致本PR被关闭了, 请移步至#90 |