Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAllSeries searchTerm mandatory in Swagger but not in code #15

Closed
bayang opened this issue Oct 25, 2019 · 2 comments
Closed

getAllSeries searchTerm mandatory in Swagger but not in code #15

bayang opened this issue Oct 25, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@bayang
Copy link

bayang commented Oct 25, 2019

When testing with swagger it is not possible to leave "search" field empty in getAllSeries endpoint which is not in adequation with code which is

fun getAllSeries(
      @AuthenticationPrincipal principal: KomgaPrincipal,
      @RequestParam("search") searchTerm: String?,

Keep up the good work anyway, this app looks very promising 👍
The metadata management is the next big thing if you can get it.

@gotson
Copy link
Owner

gotson commented Oct 26, 2019

Thanks for raising the issue, indeed it seems Spring understands well the nullable types of Kotlin, but Springfox doesn't.

@gotson gotson added the bug Something isn't working label Oct 26, 2019
@gotson gotson closed this as completed in f9c37dc Oct 26, 2019
@gotson
Copy link
Owner

gotson commented Oct 30, 2019

Released in v0.8.0

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants