Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling "Import" Feature to parse Series Title and Number to ease (Mass-)Import #998

Closed
4 tasks done
WorldTeacher opened this issue Nov 6, 2022 · 11 comments
Closed
4 tasks done
Labels
consider Not sure yet if this makes sense or not released

Comments

@WorldTeacher
Copy link

Describe your suggested feature

Enabling the Import Feature to read the comicinfo.xml file in the Archive would make (Mass-)imports easier.

As it is right now, If I want to do a mass import of, let's say 20 series that got updated, I'd do the following:

  1. go to designated import folder
  2. make subfolder for each series with new files in it
  3. in komga, go through each folder, scanning, adding Series and Number

Which is tedious and time-consuming (depending on how often the imports are performed).

If the files have a comicinfo.xml file, both the Series and Volume can be extracted from that, as they are present in the XML file:

this was made using comicrack:

<Title>Vol. 1</Title>
<Series>A Certain Scientific Railgun</Series>
<Number>1</Number>
<Volume>2011</Volume>

and this using comictagger:

<Title>Vol. 1</Title>
<Series>A Certain Scientific Railgun</Series>
<Number>1</Number>

Since in both cases the Series and Number is present, it would make importing easier and faster. If implemented, one could:

  1. put all files in the import folder (if pre-processed by e.g. comictagger)
  2. go to import, select folder
  3. wait until scan is done
  4. mass import

Which would be faster than the current process.

Other details

None that I can currently think of.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@gotson
Copy link
Owner

gotson commented Nov 7, 2022

  1. make subfolder for each series with new files in it

why?

@gotson gotson added consider Not sure yet if this makes sense or not and removed triage labels Nov 7, 2022
@WorldTeacher
Copy link
Author

3. make subfolder for each series with new files in it

why?

Because then I can add a series for all files in it, instead of adding the series for each file individually.
If I have ~50-90 Files from 20 Series it is faster to do it this way (at least for me)

@gotson
Copy link
Owner

gotson commented Nov 7, 2022

  1. make subfolder for each series with new files in it

why?

Because then I can add a series for all files in it, instead of adding the series for each file individually. If I have ~50-90 Files from 20 Series it is faster to do it this way (at least for me)

if you already do that it's probably easier to drop the files in the existing series folder, just a thought

@WorldTeacher
Copy link
Author

  1. make subfolder for each series with new files in it

why?

Because then I can add a series for all files in it, instead of adding the series for each file individually. If I have ~50-90 Files from 20 Series it is faster to do it this way (at least for me)

if you already do that it's probably easier to drop the files in the existing series folder, just a thought

Sorry for the late reply, I was away from home.

While that is an option I could choose, it requires me to do a full library scan afterwards, which takes a rather long time. If I use the Import it is added directly and no further scanning is needed

@gotson
Copy link
Owner

gotson commented Nov 8, 2022

A scan should not take a long time, you might have another issue. What is "a long time", how big is your library, and on which kind of disk/mount is it?

@WorldTeacher
Copy link
Author

A scan should not take a long time, you might have another issue. What is "a long time", how big is your library, and on which kind of disk/mount is it?

My library is ~2TB on an UnRaid Server, the disks are HDD with an SSD as cache.

As for the time, while I didn't measure it, I'd say at least an hour.

One thing I did in UnRaid was to limit Komga to 4gb RAM as I have other memory-intense processes on the server.

@gotson
Copy link
Owner

gotson commented Nov 9, 2022

As for the time, while I didn't measure it, I'd say at least an hour.

you have a problem there, a scan with no file changes should be below 20s on your setup.

I have 420gb on a NAS with SSD disks, mounted on NFS, the scan is done in milliseconds.

@WorldTeacher
Copy link
Author

WorldTeacher commented Nov 9, 2022

As for the time, while I didn't measure it, I'd say at least an hour.

you have a problem there, a scan with no file changes should be below 20s on your setup.

I have 420gb on a NAS with SSD disks, mounted on NFS, the scan is done in milliseconds.

So I took a look at the statistics, and here's the data:
ScanLibrary: 234s
RefreshSeriesMetadata: 1196s
DeleteBook: 1s
FindDuplicatePagesToDelete: 140s
GenerateBookThumbnail: 419s
AnalyzeBook: 819s
DeleteSeries: 0s
HashBook: 1076s
AggregateSeriesMetadata: 11s
RefreshBookMetadata: 129s
FindBooksToConvert: 1s
ImportBook: 49s

which totals to 4075s or 68 Minutes (this was with file changes however)

@WorldTeacher
Copy link
Author

With no file changes, the "Scan library files", the scan takes ~5 seconds

@gotson
Copy link
Owner

gotson commented Nov 10, 2022

With no file changes, the "Scan library files", the scan takes ~5 seconds

so it's fine to perform a scan often in that case

@gotson gotson changed the title [Feature Request] Enabling "Import" Feature to parse Series Title and Number to ease (Mass-)Import Enabling "Import" Feature to parse Series Title and Number to ease (Mass-)Import Jan 17, 2023
@gotson gotson closed this as completed in 5b75345 Dec 14, 2023
Copy link
Contributor

🎉 This issue has been resolved in 1.9.0 (Release Notes)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
consider Not sure yet if this makes sense or not released
Projects
None yet
Development

No branches or pull requests

2 participants