Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making exposures output idempotent #165

Closed
ernesto-jimenez opened this issue Mar 27, 2023 · 1 comment · Fixed by #204
Closed

Making exposures output idempotent #165

ernesto-jimenez opened this issue Mar 27, 2023 · 1 comment · Fixed by #204
Labels
enhancement New feature or request

Comments

@ernesto-jimenez
Copy link

Running the command twice changes the exposures file due to changes in the order of the outputs.

This results in noisy diffs which make it harder to follow what changed.

Proposal: When preparing the output, sort all arrays alphabetically.

@gouline
Copy link
Owner

gouline commented Mar 29, 2023

I'm happy with the suggested approach. However, I'm not using the exposure functionality myself, that entire area of the codebase was contributed by the community. As a result, you (or somebody else interested) will have to work on that and contribute yourself.

@gouline gouline added the enhancement New feature or request label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants