Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated documentation #53

Closed
1 task
fernandobrito opened this issue Aug 30, 2021 · 5 comments · Fixed by #58
Closed
1 task

Outdated documentation #53

fernandobrito opened this issue Aug 30, 2021 · 5 comments · Fixed by #58
Assignees
Labels
bug Something isn't working

Comments

@fernandobrito
Copy link
Contributor

An Issue to keep track of what should be updated in the docs before releasing 0.8.0:

  • Use of export models and export exposures in the CLI commands

Anything else you are aware?
I can open a PR if needed. I just wanted to do many things in one-go 😄

@gouline
Copy link
Owner

gouline commented Aug 31, 2021

Thanks for raising this, would definitely appreciate a PR for this 👍

@gouline gouline added bug Something isn't working documentation labels Aug 31, 2021
@gouline gouline added this to the v0.8.x milestone Aug 31, 2021
@z3z1ma
Copy link
Contributor

z3z1ma commented Sep 1, 2021

Hello! 👋

Correct me if I am wrong but aren't these in the docs?

image

@fernandobrito
Copy link
Contributor Author

fernandobrito commented Sep 4, 2021

@z3z1ma yes, the docs are good. Just one command example that is missing the word export and in the other one, it is missing the word models.

@gouline
Copy link
Owner

gouline commented Sep 5, 2021

I think that's a bug, export should have been replaced with models and exposures. Correct me if I'm wrong @z3z1ma?

This line should be removed https://github.com/gouline/dbt-metabase/blob/master/dbtmetabase/__init__.py#L196

@z3z1ma
Copy link
Contributor

z3z1ma commented Sep 6, 2021

Ah yes that is exactly right. The commands should simply be models and exposures
A future command is metrics

Makes it very easy to use. Good catch on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants