Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return JSON on error (game/%%/move) #47

Closed
benjaminpjones opened this issue Aug 29, 2022 · 0 comments · Fixed by #81
Closed

Return JSON on error (game/%%/move) #47

benjaminpjones opened this issue Aug 29, 2022 · 0 comments · Fixed by #81
Labels
bug Something isn't working

Comments

@benjaminpjones
Copy link
Collaborator

For some reason, html is being returned and it confuses JSON.stringify(), so the error shown isn't very useful. I think this has something to do with the fact that we are calling next() on error (a fix I had to do to deal with express not knowing how to handle unhandled promise exceptions!)

Screenshot (should say something like "you can't place a stone on an existing stone"):

Screenshot_20220829-064639_Firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant