Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty <button> tags #126

Closed
imperator99 opened this issue Apr 8, 2018 · 1 comment
Closed

Empty <button> tags #126

imperator99 opened this issue Apr 8, 2018 · 1 comment
Assignees
@imperator99
Labels
accessibility
Milestone
Sprint 10: 28/03/...

Comments

@imperator99
Copy link
Contributor

The responsive menu has two empty <button> tags.
@imperator99 imperator99 self-assigned this Apr 8, 2018
@imperator99
Copy link
Contributor Author

Further investigation shows that both aria=hidden and role=presentation attributes are added to each of these buttons. This ensures that the empty buttons are hidden to screenreaders and do not affect accessibility. They will, however, continue to fail automated checking. Further development may be required to the external mmenu library (https://github.com/FrDH/jQuery.mmenu/issues/817) to fix if this becomes an ongoing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imperator99 imperator99

Labels
accessibility
Projects
None yet
Milestone
Sprint 10: 28/03/2018 - 10/04/2018
Development

No branches or pull requests
1 participant
@imperator99