Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Selecting minified JS option causes bugs on ie8 #73

Closed
sukhrajghuman opened this issue Aug 7, 2018 · 1 comment
Closed

Selecting minified JS option causes bugs on ie8 #73

sukhrajghuman opened this issue Aug 7, 2018 · 1 comment
Labels
🐛 bug Something isn't working the way it should.

Comments

@sukhrajghuman
Copy link
Contributor

What happened

When the JS is minified option is selected as true, the side-nav doesn't open or close in ie8 on smaller devices

"js": {
		"minified": true,
		"modules": false,
		"location": "docs/js/",
		"name": "script.js"
	},

What I expected to happen

I expected the side-nav to open and close when I click it

Reproducing

  • Pancake version: v1.2.3

Steps to reproduce:

  1. As an example, run uikit-starter project on ie8 and try to open/close the accordion

  2. Then try setting the minified option to false

@alex-page
Copy link
Contributor

alex-page commented Aug 7, 2018

Should be this line of code:

const jsCode = UglifyJS.minify( js );

@pattyde pattyde added the 🐛 bug Something isn't working the way it should. label Aug 8, 2018
@pattyde pattyde added this to ✨ Done in Design System Aug 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working the way it should.
Projects
Design System
  
✨ Done
Development

No branches or pull requests

3 participants