Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Windows - Improperly escaped '\' characters #90

Open
azerella opened this issue Jan 22, 2019 · 1 comment
Open

Windows - Improperly escaped '\' characters #90

azerella opened this issue Jan 22, 2019 · 1 comment
Labels
🐛 bug Something isn't working the way it should. module: pancake An issue or pull request related to pancake.

Comments

@azerella
Copy link
Contributor

azerella commented Jan 22, 2019

It seems that the auto generated file paths when run under Windows are generated with only a single \. This needs to be generated as \\ to escape the first backslash.

The auto generated comments also fail with the backslashes:

/**
 * 
 */

e.g C:\Users\Adam needs to be generated as C:\\Users\\Adam and the comments need to be escaped as well.

A good place to start would be here: https://github.com/govau/pancake/blob/master/packages/pancake-sass/src/sass.js#L142

@azerella azerella added the 🐛 bug Something isn't working the way it should. label Jan 22, 2019
@azerella azerella added this to 🌱 Product Backlog in Design System via automation Jan 22, 2019
@azerella azerella added the module: pancake An issue or pull request related to pancake. label Jan 22, 2019
@alex-page
Copy link
Contributor

alex-page commented Jan 30, 2019

There is also an issue where @gov.au/@gov.au is appearing twice on windows. This might be related to the multiple organisation changes I did before :(

@mattparry mattparry moved this from 🌱 Product Backlog to ✏️ Sprint backlog in Design System Feb 19, 2019
@mattparry mattparry moved this from ✏️ Sprint backlog to 🌱 Product Backlog in Design System Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working the way it should. module: pancake An issue or pull request related to pancake.
Projects
Design System
  
🌱 Product Backlog
Development

No branches or pull requests

2 participants