Removed footer role contentinfo

govau · Sep 17, 2018 · 86d83d5 · 86d83d5
1 parent 6686bf7
commit 86d83d5
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 11 deletions.
diff --git a/packages/footer/CHANGELOG.md b/packages/footer/CHANGELOG.md
@@ -15,6 +15,7 @@
 
 ## Versions
 
+* [v2.1.8 - Remove `role="contentinfo"` attribute by on footer](#v218)
 * [v2.1.7 - Added an aria-label attribute to the nav element](#v217)
 * [v2.1.6 - Update dependencies](#v216)
 * [v2.1.5 - Removing web pack dev server, updating dependencies](#v215)
@@ -37,6 +38,11 @@
 
 ## Release History
 
+### v2.1.8 
+
+- Remove `role="contentinfo"` attribute by on footer
+
+
 ### v2.1.7
 
 - Added an aria-label attribute to the nav element

diff --git a/packages/footer/README.md b/packages/footer/README.md
@@ -115,6 +115,7 @@ The visual test: https://uikit.service.gov.au/packages/footer/tests/site/
 
 ## Release History
 
+* v2.1.8 - Remove `role="contentinfo"` attribute on `<footer>`
 * v2.1.7 - Added an aria-label attribute to the nav element
 * v2.1.6 - Update dependencies
 * v2.1.5 - Removing web pack dev server, updating dependencies

diff --git a/packages/footer/package.json b/packages/footer/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "@gov.au/footer",
-	"version": "2.1.7",
+	"version": "2.1.8",
 	"description": "Footers help users who reach the bottom of a page without finding what they want.",
 	"keywords": [
 		"uikit",
@@ -127,6 +127,11 @@
 			"name": "Christopher Rodriguez",
 			"email": "christopher.rodriguez@digital.gov.au",
 			"url": "https://github.com/xochi"
+		},
+		{
+			"name": "Sukhraj Ghuman",
+			"email": "sukhrajghuman@live.com",
+			"url": "https://github.com/sukhrajghuman"
 		}
 	],
 	"license": "MIT"

diff --git a/packages/footer/src/js/react.js b/packages/footer/src/js/react.js
@@ -75,7 +75,6 @@ AUfooterEnd.propTypes = {
 const AUfooter = ({ dark, alt, children, className = '', ...attributeOptions }) => (
 	<footer
 		className={ `au-footer ${ className }${ dark ? ' au-footer--dark' : '' }${ alt ? ' au-footer--alt' : '' } `}
-		role="contentinfo"
 		{ ...attributeOptions }
 	>
 		{ children }

diff --git a/packages/footer/tests/site/index.html b/packages/footer/tests/site/index.html
@@ -46,7 +46,7 @@ <h1>Test: footer</h1>
 
 	<h2>footer</h2>
 
-	<footer class="au-footer" role="contentinfo">
+	<footer class="au-footer">
 		<nav class="au-footer__navigation" aria-label="footer navigation">
 			<p>au-footer__navigation</p>
 		</nav>
@@ -58,7 +58,7 @@ <h2>footer</h2>
 
 	<h2>footer <code>--alt</code></h2>
 
-	<footer class="au-footer au-footer--alt" role="contentinfo">
+	<footer class="au-footer au-footer--alt">
 		<nav class="au-footer__navigation" aria-label="footer navigation">
 			<p>au-footer__navigation</p>
 		</nav>
@@ -70,7 +70,7 @@ <h2>footer <code>--alt</code></h2>
 
 	<h2>footer <code>--dark</code></h2>
 
-	<footer class="au-footer au-footer--dark" role="contentinfo">
+	<footer class="au-footer au-footer--dark">
 		<nav class="au-footer__navigation" aria-label="footer navigation">
 			<p>au-footer__navigation</p>
 		</nav>
@@ -82,7 +82,7 @@ <h2>footer <code>--dark</code></h2>
 
 	<h2>footer <code>--alt</code> <code>--dark</code></h2>
 
-	<footer class="au-footer au-footer--alt au-footer--dark" role="contentinfo">
+	<footer class="au-footer au-footer--alt au-footer--dark">
 		<nav class="au-footer__navigation" aria-label="footer navigation">
 			<p>au-footer__navigation</p>
 		</nav>
@@ -96,7 +96,7 @@ <h2>footer <code>--alt</code> <code>--dark</code></h2>
 	<h2>footer with paragraph test and body</h2>
 
 	<div class="au-body">
-		<footer class="au-footer" role="contentinfo">
+		<footer class="au-footer">
 			<nav class="au-footer__navigation" aria-label="footer navigation">
 				<p>au-footer__navigation</p>
 				<p>au-footer__navigation</p>
@@ -113,7 +113,7 @@ <h2>footer with paragraph test and body</h2>
 	<hr>
 	<h2>footer navigation only</h2>
 
-	<footer class="au-footer" role="contentinfo">
+	<footer class="au-footer">
 		<nav class="au-footer__navigation" aria-label="footer navigation">
 			<p>au-footer__navigation</p>
 		</nav>
@@ -122,7 +122,7 @@ <h2>footer navigation only</h2>
 	<hr>
 	<h2>footer end only</h2>
 
-	<footer class="au-footer" role="contentinfo">
+	<footer class="au-footer">
 		<section class="au-footer__end">
 			<p>au-footer__end</p>
 		</section>
@@ -132,7 +132,7 @@ <h2>footer end only</h2>
 	<h2>footer with grid, link-list, responsive-embeds and headings</h2>
 
 	<div class="au-grid au-body">
-		<footer class="au-footer" role="contentinfo">
+		<footer class="au-footer">
 			<div class="container">
 				<nav class="au-footer__navigation row" aria-label="footer navigation">
 					<div class="col-md-3 col-sm-6">
@@ -186,7 +186,7 @@ <h3 class="au-display-lg">Section</h3>
 	</div>
 
 	<div class="au-grid au-body au-body--dark">
-		<footer class="au-footer au-footer--dark" role="contentinfo">
+		<footer class="au-footer au-footer--dark">
 			<div class="container">
 				<nav class="au-footer__navigation row" aria-label="footer navigation">
 					<div class="col-md-3 col-sm-6">