Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce DOM size #333

Open
RVA2869 opened this issue Dec 5, 2023 · 7 comments
Open

Reduce DOM size #333

RVA2869 opened this issue Dec 5, 2023 · 7 comments
Labels
enhancement 🥇 New feature or request

Comments

@RVA2869
Copy link
Contributor

RVA2869 commented Dec 5, 2023

The feature

Not so much a feature, but we can remove the logos from the country page. (And move them to the agency page)

Why?

  • better performance
  • better SEO
  • reducing the amount of data that needs to be transferred each time
  • ...

Examples and inspiration

Google PageSpeed Insights (Belgium) 13961 elements
Google PageSpeed Insights (Sweden) 10469 elements

@RVA2869 RVA2869 added the enhancement 🥇 New feature or request label Dec 5, 2023
@RVA2869
Copy link
Contributor Author

RVA2869 commented Dec 5, 2023

@Ainali
Copy link
Member

Ainali commented Dec 5, 2023

Do you mean our logos or the social media icons?

@RVA2869
Copy link
Contributor Author

RVA2869 commented Dec 5, 2023

Do you mean our logos or the social media icons?

Yes, That is the main cause of the excessive DOM size, the table is something necessary (for now)

@Ainali
Copy link
Member

Ainali commented Dec 5, 2023

I'm sorry for phrasing the question so poorly, I'll try to make it unambiguous by splitting it into two questions:

  1. Do you mean that we should remove our logos?
  2. Do you mean that we should remove the social media icons?

@RVA2869
Copy link
Contributor Author

RVA2869 commented Dec 5, 2023

The problem is not so much the (social media) logos/icons, but each of them has a unique link and that is what makes the DOM size so large (among other things). Removing the social media links would be a solution. From the country page, though.😉

@Ainali
Copy link
Member

Ainali commented Dec 5, 2023

Aha. That would add some clicks to get to the link, though, and removing the icons would remove the clue that the org is worth clicking on.
For myself, I often use the country page to get an overview of where works need to be done.
It would be great if we could do some user research to see how the links are used and where they make sense for the users.

@Abbe98
Copy link
Member

Abbe98 commented Dec 8, 2023

I would be worried about the DOM parsing we do for the "filtering" feature but it seems to work for now even on slow devices(tested on a Pinephone).

If it becomes a problem we should maybe come up with a better solution to long lists, things like #212 and in the worst case default to pagination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🥇 New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants