Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression testing #65

Closed
penx opened this issue Feb 12, 2018 · 6 comments
Closed

Visual regression testing #65

penx opened this issue Feb 12, 2018 · 6 comments

Comments

@penx
Copy link
Member

penx commented Feb 12, 2018

Add support for visual regression testing by:

  1. for each component that has an 'example.js' file, generate an image snapshot with Pupeteer component-image (this is done as part of API docs)
  2. plug component-image in to a dockerized puppeteer so that identical images are always generated independent of host platform
  3. make the CI server check that the generated images in the docs folder match the current image snapshots for example.js
@penx
Copy link
Member Author

penx commented Feb 12, 2018

puppeteer/puppeteer#1645

@penx
Copy link
Member Author

penx commented Feb 12, 2018

@penx penx mentioned this issue Feb 12, 2018
@penx
Copy link
Member Author

penx commented Mar 6, 2018

I think due to:

  • our Jest snapshot testing now outputs CSS
  • cross platform anti aliasing issues still being a pain

There is less value in introducing visual regression testing.

However, as we do have image generation for each component for the purpose of the API documentation generation, it is a logical progression to introduce some very simple visual regression tests if we can use dockerized puppeteer to resolve the issues with cross platform rendering differences.

@penx
Copy link
Member Author

penx commented Apr 14, 2018

@penx
Copy link
Member Author

penx commented Apr 23, 2018

chromatic has been added - need to start using it

@penx penx mentioned this issue Apr 24, 2018
@penx
Copy link
Member Author

penx commented Oct 26, 2018

Chromatic is being used but:

  • we have a lot of stories being nested in 'Example' folders which makes it hard to navigate in the Chromatic UI
  • sometimes changes are flagged on PRs that are not related to the PR

@penx penx closed this as completed Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant